Issue 18095002: Merge 208596 "Pipe a bit down to the InstantExtended new tab pag..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18095002: Merge 208596 "Pipe a bit down to the InstantExtended new tab pag..." (Closed)

Created:
7 years, 5 months ago by Jered

Modified:
7 years, 5 months ago

Reviewers:
David Black

CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1547/src/

Visibility:
Public.

More Reviews

Description

Merge 208596 "Pipe a bit down to the InstantExtended new tab pag..." > Pipe a bit down to the InstantExtended new tab page javascript API for whether or not the app launcher is enabled. > > BUG=252867 > > Review URL: https://chromiumcodereview.appspot.com/17699006 TBR=dcblack@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208941

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -0 lines)			Patch
M	chrome/browser/ui/search/instant_controller.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
MM	chrome/browser/ui/search/instant_ipc_sender.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
MM	chrome/browser/ui/search/instant_ipc_sender.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/instant_page.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/instant_page.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/resources/extensions/searchbox_api.js	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox.h	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox.cc	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox_extension.cc	View	3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r208941.

Expand Messages | Collapse Messages