Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1809463002: [Media Router WebUI] Open links in a new tab. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Open links in a new tab. Open all links from the dialog (JS side) in a new tab. This prevents navigating the user away from whatever they're currently doing on the current active tab. The dialog remains open on the original tab. URLs that are opened on the C++ side already open in a new tab. BUG=594653 Committed: https://crrev.com/55669d8f6ed1ad73e0991c0285a1e3947d3e785e Cr-Commit-Position: refs/heads/master@{#381822}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
apacible
PTAL, thanks! Tested on mac and linux.
4 years, 9 months ago (2016-03-15 21:29:14 UTC) #4
imcheng
lgtm
4 years, 9 months ago (2016-03-17 18:36:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809463002/20001
4 years, 9 months ago (2016-03-17 22:09:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 22:52:51 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 22:53:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55669d8f6ed1ad73e0991c0285a1e3947d3e785e
Cr-Commit-Position: refs/heads/master@{#381822}

Powered by Google App Engine
This is Rietveld 408576698