Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1809403002: [compiler] Readability refactor of comilation pipeline. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Readability refactor of comilation pipeline. This is a pure refactoring CL and should not contain any functional changes to the code. The following has been done: - Group compiler.cc into sections for each component. - Surround local helper methods by anonymous namespace. - Move implementation of Compiler (API class) together. R=yangguo@chromium.org Committed: https://crrev.com/6691814f580247041b80ee828bd736df0d3c68bb Cr-Commit-Position: refs/heads/master@{#34891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -191 lines) Patch
M src/compiler.cc View 20 chunks +186 lines, -191 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-18 12:56:11 UTC) #1
Yang
On 2016/03/18 12:56:11, Michael Starzinger wrote: lgtm.
4 years, 9 months ago (2016-03-18 13:18:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809403002/1
4 years, 9 months ago (2016-03-18 13:55:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 13:57:01 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 13:57:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6691814f580247041b80ee828bd736df0d3c68bb
Cr-Commit-Position: refs/heads/master@{#34891}

Powered by Google App Engine
This is Rietveld 408576698