Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1809383002: [libfuzzer] Prevent division by zero in libpng_read_fuzzer. (Closed)

Created:
4 years, 9 months ago by mmoroz
Modified:
4 years, 9 months ago
Reviewers:
krasin1, aizatsky, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] Prevent division by zero in libpng_read_fuzzer. R=aizatsky@chromium.org, inferno@chromium.org, krasin@chromium.org BUG=584819 Committed: https://crrev.com/ad979b9da26926eee41d00bd8137ab69079d267f Cr-Commit-Position: refs/heads/master@{#382315}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 10 (2 generated)
mmoroz
4 years, 9 months ago (2016-03-18 09:34:07 UTC) #1
inferno
lgtm
4 years, 9 months ago (2016-03-18 12:26:56 UTC) #2
aizatsky
https://codereview.chromium.org/1809383002/diff/1/testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc File testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc (right): https://codereview.chromium.org/1809383002/diff/1/testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc#newcode95 testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc:95: if (width && height > 100000000 / width) Is ...
4 years, 9 months ago (2016-03-18 17:18:18 UTC) #3
mmoroz
https://codereview.chromium.org/1809383002/diff/1/testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc File testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc (right): https://codereview.chromium.org/1809383002/diff/1/testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc#newcode95 testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc:95: if (width && height > 100000000 / width) On ...
4 years, 9 months ago (2016-03-21 09:07:38 UTC) #4
aizatsky
lgtm
4 years, 9 months ago (2016-03-21 16:48:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809383002/1
4 years, 9 months ago (2016-03-21 16:49:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 17:20:20 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 17:23:06 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ad979b9da26926eee41d00bd8137ab69079d267f
Cr-Commit-Position: refs/heads/master@{#382315}

Powered by Google App Engine
This is Rietveld 408576698