Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1809363002: [mojo-edk] Stop using the sync broker on OS X (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Stop using the sync broker on OS X The sync broker is only needed for sandboxed shared buffer allocation on POSIX, but it's not needed for Mach shared buffers. This stops using the broker on OS X. BUG=591742, 590979 Committed: https://crrev.com/018a4e46c477ada7307ed5c7dad7eb58b7da75b5 Cr-Commit-Position: refs/heads/master@{#381908}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M mojo/edk/system/node_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/node_controller.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Ken Rockot(use gerrit already)
4 years, 9 months ago (2016-03-18 05:12:44 UTC) #2
Anand Mistry (off Chromium)
LGTM https://codereview.chromium.org/1809363002/diff/1/mojo/edk/system/node_controller.cc File mojo/edk/system/node_controller.cc (right): https://codereview.chromium.org/1809363002/diff/1/mojo/edk/system/node_controller.cc#newcode221 mojo/edk/system/node_controller.cc:221: // TODO(amistry): Fix sync broker and re-enable on ...
4 years, 9 months ago (2016-03-18 05:40:12 UTC) #3
Ken Rockot(use gerrit already)
On 2016/03/18 at 05:40:12, amistry wrote: > LGTM > > https://codereview.chromium.org/1809363002/diff/1/mojo/edk/system/node_controller.cc > File mojo/edk/system/node_controller.cc (right): ...
4 years, 9 months ago (2016-03-18 05:57:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809363002/20001
4 years, 9 months ago (2016-03-18 05:58:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 07:34:43 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 07:36:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/018a4e46c477ada7307ed5c7dad7eb58b7da75b5
Cr-Commit-Position: refs/heads/master@{#381908}

Powered by Google App Engine
This is Rietveld 408576698