Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1809333002: X87: InstanceOfStub incorrectly interprets the hole as a prototype. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: InstanceOfStub incorrectly interprets the hole as a prototype. port 2aa070be4fd2960df98905b254f12ed801ef26cd (r34863) original commit message: Repair this to match what the runtime correctly does, by first checking if the function is a constructor before we access the prototype. BUG= Committed: https://crrev.com/5b5d24b308ae48c49480c943049f9c1a7eda5aa7 Cr-Commit-Position: refs/heads/master@{#34880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-18 02:57:41 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-18 07:22:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809333002/1
4 years, 9 months ago (2016-03-18 07:25:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 07:48:44 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 07:50:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b5d24b308ae48c49480c943049f9c1a7eda5aa7
Cr-Commit-Position: refs/heads/master@{#34880}

Powered by Google App Engine
This is Rietveld 408576698