pkg/polymer/test/build/all_phases_test.dart - Issue 180933002: combine script extractor and import inliner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/test/build/all_phases_test.dart

Issue 180933002: combine script extractor and import inliner (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: refactor Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/polymer/lib/src/build/import_inliner.dart ('K') | « pkg/polymer/lib/transformer.dart ('k') | pkg/polymer/test/build/code_extractor.dart » ('j') | pkg/polymer/test/build/code_extractor.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/polymer/test/build/all_phases_test.dart

diff --git a/pkg/polymer/test/build/all_phases_test.dart b/pkg/polymer/test/build/all_phases_test.dart

index 6633eb132918eaa3d46ce89f8179b0cd22907980..a85b3fc21ce689c491e7c56abdb92dba6fbc6dfb 100644

--- a/pkg/polymer/test/build/all_phases_test.dart

+++ b/pkg/polymer/test/build/all_phases_test.dart

@@ -65,8 +65,9 @@ void main() {

'<!DOCTYPE html><html><head>'

'$WEB_COMPONENTS_TAG'

'$INTEROP_TAG'

+ '</head><body>'

'<script src="test.html_bootstrap.dart.js"></script>'

- '</head><body></body></html>',

+ '</body></html>',

'a|web/test.html_bootstrap.dart':

'''$MAIN_HEADER

@@ -103,8 +104,8 @@ void main() {

'<!DOCTYPE html><html><head>'

'$WEB_COMPONENTS_TAG'

'$INTEROP_TAG'

- '<script src="test.html_bootstrap.dart.js"></script>'

'</head><body>'

+ '<script src="test.html_bootstrap.dart.js"></script>'

'<div></div>'

'</body></html>',

@@ -119,8 +120,6 @@ void main() {

}

'''.replaceAll('\n ', '\n'),

'a|web/a.dart': _sampleObservableOutput('A', 'foo'),

Siggi Cherem (dart-lang) 2014/02/26 22:27:09 consider providing also the expectedMessages argum

Jennifer Messerly 2014/02/27 22:31:40 done. All of our warnings are emitted too much (I

- 'a|web/test.html.0.dart': _sampleObservableOutput("B", "bar"),

- 'a|web/test.html.1.dart': _sampleObservableOutput("C", "car"),

});

testPhases('with imports', phases, {

@@ -146,7 +145,7 @@ void main() {

'</body></html>',

'a|web/index.html_bootstrap.dart':

'''$MAIN_HEADER

- import 'test2.html.0.dart' as i0;

+ import 'index.html.0.dart' as i0;

import 'b.dart' as i1;

void main() {

@@ -155,7 +154,7 @@ void main() {

i1.main();

}

'''.replaceAll('\n ', '\n'),

- 'a|web/test2.html.0.dart': _sampleObservableOutput("A", "foo"),

+ 'a|web/index.html.0.dart': _sampleObservableOutput("A", "foo"),

'a|web/b.dart': _sampleObservableOutput('B', 'bar'),

});

}