Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1809323002: ChannelMojo: Remove intermediate Message struct (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
Sam McNally
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChannelMojo: Remove intermediate Message struct This passes the data and handles directly in the Receive message rather than using an intermediate Message struct. One less alloc per Send, which seems worthwhile even though the performance delta is marginal. R=sammc@chromium.org BUG= Committed: https://crrev.com/9691a7bf20f969e72b523e5006823901e34cd825 Cr-Commit-Position: refs/heads/master@{#382037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M ipc/mojo/ipc.mojom View 1 chunk +1 line, -6 lines 0 comments Download
M ipc/mojo/ipc_message_pipe_reader.h View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/mojo/ipc_message_pipe_reader.cc View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
4 years, 9 months ago (2016-03-18 02:17:41 UTC) #1
Sam McNally
lgtm
4 years, 9 months ago (2016-03-18 17:48:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809323002/1
4 years, 9 months ago (2016-03-18 18:08:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 18:58:26 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 18:59:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9691a7bf20f969e72b523e5006823901e34cd825
Cr-Commit-Position: refs/heads/master@{#382037}

Powered by Google App Engine
This is Rietveld 408576698