build/toolchain/win/BUILD.gn - Issue 1809273002: Enable whole-program virtual function optimization in LTO mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/win/BUILD.gn

Issue 1809273002: Enable whole-program virtual function optimization in LTO mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename one more instance of is_lto Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/win/BUILD.gn

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn

index 7c359b8128194af20cd39b72079f930ef7f0c8bb..d56f6069681847c4496756e35042c7c6a6dd3bef 100644

--- a/build/toolchain/win/BUILD.gn

+++ b/build/toolchain/win/BUILD.gn

@@ -25,7 +25,7 @@ if (use_goma) {

}

# This value will be inherited in the toolchain below.

-if (is_lto) {

+if (allow_posix_link_time_opt) {

brettw 2016/04/06 06:25:36 This seems super weird in the Windows toolchain fi

pcc1 2016/04/06 21:42:01 Agreed. We don't even have LLVM LTO stuff ported t

pcc1 2016/04/06 21:44:23 (I mean LLVM LTO on Windows, of course.)

concurrent_links =

exec_script("../get_concurrent_links.py", [ "--lto" ], "value")

} else {

« build/config/compiler/BUILD.gn ('K') | « build/toolchain/toolchain.gni ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »