Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1809253002: Remove a slightly overzealous CHECK that's causing crashes in canary. (Closed)

Created:
4 years, 9 months ago by Ilya Kulshin
Modified:
4 years, 9 months ago
Reviewers:
ananta
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a slightly overzealous CHECK that's causing crashes in canary. BUG=595789 Committed: https://crrev.com/90e07346788aeb1ec2c24c13f3a5fc00325f1eb1 Cr-Commit-Position: refs/heads/master@{#381867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Ilya Kulshin
ptal
4 years, 9 months ago (2016-03-17 21:50:00 UTC) #2
ananta
lgtm
4 years, 9 months ago (2016-03-17 22:44:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809253002/1
4 years, 9 months ago (2016-03-17 23:03:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/190824)
4 years, 9 months ago (2016-03-18 00:30:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809253002/1
4 years, 9 months ago (2016-03-18 00:37:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 01:41:12 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 01:42:59 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/90e07346788aeb1ec2c24c13f3a5fc00325f1eb1
Cr-Commit-Position: refs/heads/master@{#381867}

Powered by Google App Engine
This is Rietveld 408576698