Add new NSPasteboard utility function and tests.

Add new NSPasteboard utility function and tests.

The function PasteboardItemFromUrl converts a url and title into an
NSPasteboardItem.

BUG=596128
Committed: https://crrev.com/c7cbcac75b856e25c377f78db22232438a09b87a
Cr-Commit-Position: refs/heads/master@{#382374}

[erikchen, 2016-03-18 23:39:39]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 23:40:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809243004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809243004/20001

[erikchen, 2016-03-19 00:50:59]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-03-19 00:50:59]

avi: Please review.

[commit-bot: I haz the power, 2016-03-19 01:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 01:11:42]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-03-19 01:15:21]

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
File ui/base/clipboard/clipboard_util_mac.mm (right):

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:20: return
[static_cast<NSString*>(UTTypeCreatePreferredIdentifierForTag(
base::mac::CFToNSCast?

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:21: kUTTagClassNSPboardType,
static_cast<CFStringRef>(type), kUTTypeData))
base::mac::NSToCFCast?

Also, why specify conformance with kUTTypeData? Why not just say null there and
not worry?

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:22: autorelease];
And technically speaking you should use
base::mac::CFTypeRefToNSObjectAutorelease but that's borderline obsolete now so
I don't really mind either way.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:51: NSURL *base = [url baseURL];
space after *

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:58: }
Can you provide documentation or a link about why this split between relative
and absolute and base url for NSURLPboardType?

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:63: [item setData:[NSData
dataWithBytes:tempCString length:strlen(tempCString)]
Why not do [urlString dataUsingEncoding:NSUTF8StringEncoding]?

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:64:
forType:UTIFromPboardType(kCorePasteboardFlavorType_url)];
indent one fewer to align colons

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:67: [item setData:[NSData
dataWithBytes:tempCString length:strlen(tempCString)]
[title dataUsingEncoding:NSUTF8StringEncoding]?

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:68:
forType:UTIFromPboardType(kCorePasteboardFlavorType_urln)];
indent one fewer, align on :

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
File ui/base/clipboard/clipboard_util_mac_unittest.mm (right):

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac_unittest.mm:80: }  // namespace
Can we have tests that don't use the Mozilla code? In particular, APIs from
Foundation might not be a bad idea to run.

+[NSURL URLFromPasteboard:] perhaps?

[erikchen, 2016-03-21 18:26:38]

avi: PTAL

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
File ui/base/clipboard/clipboard_util_mac.mm (right):

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:20: return
[static_cast<NSString*>(UTTypeCreatePreferredIdentifierForTag(
On 2016/03/19 01:15:20, Avi wrote:
> base::mac::CFToNSCast?

Done.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:21: kUTTagClassNSPboardType,
static_cast<CFStringRef>(type), kUTTypeData))
On 2016/03/19 01:15:20, Avi wrote:
> base::mac::NSToCFCast?
> 
> Also, why specify conformance with kUTTypeData? Why not just say null there
and
> not worry?

Done.

According to SO, we shouldn't pass null. This works, and I didn't want to spend
time figuring out whether there were weird edge cases where null doesn't work.
http://stackoverflow.com/questions/3259807/why-doesnt-nspasteboards-types-ret...

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:22: autorelease];
On 2016/03/19 01:15:20, Avi wrote:
> And technically speaking you should use
> base::mac::CFTypeRefToNSObjectAutorelease but that's borderline obsolete now
so
> I don't really mind either way.

I kept -autorelease.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:51: NSURL *base = [url baseURL];
On 2016/03/19 01:15:20, Avi wrote:
> space after *

Done.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:58: }
On 2016/03/19 01:15:20, Avi wrote:
> Can you provide documentation or a link about why this split between relative
> and absolute and base url for NSURLPboardType?

Done.

The format of the property list come straight from WebKit.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:63: [item setData:[NSData
dataWithBytes:tempCString length:strlen(tempCString)]
On 2016/03/19 01:15:20, Avi wrote:
> Why not do [urlString dataUsingEncoding:NSUTF8StringEncoding]?

I was copy-pasting from the old Mozilla code. I changed the code to use your
suggestion.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:64:
forType:UTIFromPboardType(kCorePasteboardFlavorType_url)];
On 2016/03/19 01:15:20, Avi wrote:
> indent one fewer to align colons

Done.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:67: [item setData:[NSData
dataWithBytes:tempCString length:strlen(tempCString)]
On 2016/03/19 01:15:20, Avi wrote:
> [title dataUsingEncoding:NSUTF8StringEncoding]?

Done.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:68:
forType:UTIFromPboardType(kCorePasteboardFlavorType_urln)];
On 2016/03/19 01:15:20, Avi wrote:
> indent one fewer, align on :

Done.

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
File ui/base/clipboard/clipboard_util_mac_unittest.mm (right):

https://codereview.chromium.org/1809243004/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac_unittest.mm:80: }  // namespace
On 2016/03/19 01:15:20, Avi wrote:
> Can we have tests that don't use the Mozilla code? In particular, APIs from
> Foundation might not be a bad idea to run.
> 
> +[NSURL URLFromPasteboard:] perhaps?

Good suggestion. I've added to each test to check the pasteboard using both
Mozilla code and Foundation code.

[Avi (use Gerrit), 2016-03-21 18:30:39]

lgtm

https://codereview.chromium.org/1809243004/diff/40001/ui/base/clipboard/clipb...
File ui/base/clipboard/clipboard_util_mac.mm (right):

https://codereview.chromium.org/1809243004/diff/40001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_util_mac.mm:51: // Set NSURLPboardType. The format
of the property list is divined from
Haha sob.

The word "divine" as a source of documentation says it all.

[erikchen, 2016-03-21 19:21:56]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-03-21 19:22:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809243004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809243004/40001

[commit-bot: I haz the power, 2016-03-21 20:36:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-21 20:37:54]

Description was changed from

==========
Add new NSPasteboard utility function and tests.

The function PasteboardItemFromUrl converts a url and title into an
NSPasteboardItem.

BUG=596128
==========

to

==========
Add new NSPasteboard utility function and tests.

The function PasteboardItemFromUrl converts a url and title into an
NSPasteboardItem.

BUG=596128

Committed: https://crrev.com/c7cbcac75b856e25c377f78db22232438a09b87a
Cr-Commit-Position: refs/heads/master@{#382374}
==========

[commit-bot: I haz the power, 2016-03-21 20:37:55]

Patchset 3 (id:??) landed as
https://crrev.com/c7cbcac75b856e25c377f78db22232438a09b87a
Cr-Commit-Position: refs/heads/master@{#382374}