Throw exceptions from CreateDataProperty when should_throw

Throw exceptions from CreateDataProperty when should_throw

Previously, when a property was non-configurable or the object was
non-extensible, CreateDataProperty might just return false rather than
throwing, even if should_throw was on. This patch fixes that issue.

Tested by running the patch at https://codereview.chromium.org/1814933002
on top of this code and observing the tests to see an exception thrown.

R=adamk
BUG=chromium:595319
LOG=Y

Committed: https://crrev.com/67bee8149a6d3d02f1e349919cbe86d87b452128
Cr-Commit-Position: refs/heads/master@{#34875}

[Dan Ehrenberg, 2016-03-17 21:14:43]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 21:14:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809233002/1

[adamk, 2016-03-17 21:22:06]

lgtm % nit

https://codereview.chromium.org/1809233002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1809233002/diff/1/src/objects.cc#newcode6738
src/objects.cc:6738: if
(!JSObject::IsExtensible(Handle<JSObject>::cast(it->GetReceiver())))
Nit: please add braces around the body of this if statement.

[Dan Ehrenberg, 2016-03-17 21:25:28]

https://codereview.chromium.org/1809233002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1809233002/diff/1/src/objects.cc#newcode6738
src/objects.cc:6738: if
(!JSObject::IsExtensible(Handle<JSObject>::cast(it->GetReceiver())))
On 2016/03/17 at 21:22:06, adamk wrote:
> Nit: please add braces around the body of this if statement.

Done

[Dan Ehrenberg, 2016-03-17 21:25:35]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-17 21:25:35]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1809233002/#ps20001
(title: "brackets")

[commit-bot: I haz the power, 2016-03-17 21:25:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809233002/20001

[commit-bot: I haz the power, 2016-03-17 21:51:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-17 21:52:41]

Description was changed from

==========
Throw exceptions from CreateDataProperty when should_throw

Previously, when a property was non-configurable or the object was
non-extensible, CreateDataProperty might just return false rather than
throwing, even if should_throw was on. This patch fixes that issue.

Tested by running the patch at https://codereview.chromium.org/1814933002
on top of this code and observing the tests to see an exception thrown.

R=adamk
BUG=chromium:595319
LOG=Y
==========

to

==========
Throw exceptions from CreateDataProperty when should_throw

Previously, when a property was non-configurable or the object was
non-extensible, CreateDataProperty might just return false rather than
throwing, even if should_throw was on. This patch fixes that issue.

Tested by running the patch at https://codereview.chromium.org/1814933002
on top of this code and observing the tests to see an exception thrown.

R=adamk
BUG=chromium:595319
LOG=Y

Committed: https://crrev.com/67bee8149a6d3d02f1e349919cbe86d87b452128
Cr-Commit-Position: refs/heads/master@{#34875}
==========

[commit-bot: I haz the power, 2016-03-17 21:52:42]

Patchset 2 (id:??) landed as
https://crrev.com/67bee8149a6d3d02f1e349919cbe86d87b452128
Cr-Commit-Position: refs/heads/master@{#34875}