Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1809223002: Remove some CSSParserMode parameters in CSSPropertyParser (Closed)

Created:
4 years, 9 months ago by rwlbuis
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some CSSParserMode parameters in CSSPropertyParser Remove some CSSParserMode parameters in CSSPropertyParser, these are not needed anymore because of various refactorings. BUG=499780 Committed: https://crrev.com/ee65b1837bda62540b61e93677c4f259cae09fdd Cr-Commit-Position: refs/heads/master@{#387274}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 12 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rwlbuis
PTAL. I can't pinpoint 100% why this is not needed anymore (changes in consumeLength/consumeNumber/consumeInteger?) but ...
4 years, 8 months ago (2016-04-13 22:32:40 UTC) #4
Timothy Loh
On 2016/04/13 22:32:40, rwlbuis wrote: > PTAL. > > I can't pinpoint 100% why this ...
4 years, 8 months ago (2016-04-14 02:05:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809223002/20001
4 years, 8 months ago (2016-04-14 08:46:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 09:55:33 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 09:56:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee65b1837bda62540b61e93677c4f259cae09fdd
Cr-Commit-Position: refs/heads/master@{#387274}

Powered by Google App Engine
This is Rietveld 408576698