Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1809213002: Remove hidePrintWithSystemDialog disableability (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove hidePrintWithSystemDialog disableability Only used for Metro on Windows, which no longer exists. R=dpapad@chromium.org BUG=558054 Committed: https://crrev.com/fbb8280085f05360997eeab81d4e042928062ef6 Cr-Commit-Position: refs/heads/master@{#381803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M chrome/browser/resources/print_preview/native_layer.js View 4 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
scottmg
4 years, 9 months ago (2016-03-17 20:23:15 UTC) #2
dpapad
lgtm
4 years, 9 months ago (2016-03-17 20:51:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809213002/1
4 years, 9 months ago (2016-03-17 20:56:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 21:43:11 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 21:44:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbb8280085f05360997eeab81d4e042928062ef6
Cr-Commit-Position: refs/heads/master@{#381803}

Powered by Google App Engine
This is Rietveld 408576698