Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1809203003: [Chromecast] Improve rendering delay accuracy by tracking partial samples (Closed)

Created:
4 years, 9 months ago by kmackay
Modified:
4 years, 9 months ago
Reviewers:
halliwell, jyw
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Improve rendering delay accuracy by tracking partial samples The resampler can partially consume audio samples (since when resampling, one output sample can correspond to fractional input samples). By keeping track of the partially-consumed samples, we can improve the accuracy of the estimated rendering delay. BUG= Committed: https://crrev.com/245a437a091ffe2d4ad2baa298b451acc937c08e Cr-Commit-Position: refs/heads/master@{#381832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.cc View 4 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kmackay
4 years, 9 months ago (2016-03-17 21:11:42 UTC) #2
halliwell
On 2016/03/17 21:11:42, kmackay wrote: lgtm
4 years, 9 months ago (2016-03-17 21:23:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809203003/1
4 years, 9 months ago (2016-03-17 22:47:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 23:22:55 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 23:25:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/245a437a091ffe2d4ad2baa298b451acc937c08e
Cr-Commit-Position: refs/heads/master@{#381832}

Powered by Google App Engine
This is Rietveld 408576698