Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/rebaseline_imagefiles.py

Issue 18092004: rebaseline.py: add --keep-going-on-failure option, off by default (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/rebaseline_imagefiles.py
===================================================================
--- tools/rebaseline_imagefiles.py (revision 10046)
+++ tools/rebaseline_imagefiles.py (working copy)
@@ -278,15 +278,8 @@
continue
outfilename = os.path.join(self._expectations_root, subdir,
filename);
- # TODO(epoger): Until we resolve
- # https://code.google.com/p/skia/issues/detail?id=1410 ('some GM
- # result images not available for download from Google Storage'),
- # keep going in the face of missing results for any one test.
- try:
- self._RebaselineOneFile(expectations_subdir=subdir,
- builder_name=builder,
- infilename=filename,
- outfilename=outfilename,
- all_results=all_results)
- except Exception as e:
- print 'WARNING: swallowing exception %s' % e
+ self._RebaselineOneFile(expectations_subdir=subdir,
+ builder_name=builder,
+ infilename=filename,
+ outfilename=outfilename,
+ all_results=all_results)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698