Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: third_party/WebKit/Source/core/style/GridPositionsResolver.cpp

Issue 1809143002: [css-grid] Fix wrong type in GridPositionsResolver method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@grid-span-last-rename
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/GridPositionsResolver.cpp
diff --git a/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp b/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp
index 6ea7d7aea85f3a0481eeb3aec630fd6a1aa34169..9d116e82b5d95455db83e02ed68cee04d7a819b1 100644
--- a/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp
+++ b/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp
@@ -150,7 +150,7 @@ static GridSpan resolveNamedGridLinePositionAgainstOppositePosition(const Comput
return definiteGridSpanWithNamedSpanAgainstOpposite(opossiteLine, position, side, gridLines, lastLine);
}
-static GridSpan definiteGridSpanWithSpanAgainstOpposite(size_t opossiteLine, const GridPosition& position, GridPositionSide side)
+static GridSpan definiteGridSpanWithSpanAgainstOpposite(int opossiteLine, const GridPosition& position, GridPositionSide side)
rune 2016/03/17 18:30:16 oppositeLine ?
Manuel Rego 2016/03/18 09:40:02 Yeah, sure the typo should be fixed actually in: h
{
size_t positionOffset = position.spanPosition();
if (side == ColumnStartSide || side == RowStartSide)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698