Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1809123003: [Interpreter] Fixes CopyBytecodeArray to copy interrupt_budget field. (Closed)

Created:
4 years, 9 months ago by mythria
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fixes CopyBytecodeArray to copy interrupt_budget field. Fixes CopyBytecodeArray to set the interrupt_budget field. BUG=v8:4280, v8:4690 LOG=N Committed: https://crrev.com/27338320f450a6d41c1fa2dfeae62d3a1aef3e86 Cr-Commit-Position: refs/heads/master@{#34982}

Patch Set 1 #

Patch Set 2 : updated mjsunit.status #

Patch Set 3 : Skips tests that timeout on msan. #

Patch Set 4 : Skipping another flaky test on msan. #

Patch Set 5 : rebased the patch. #

Patch Set 6 : Updates cctest.status to enable debug tests. Skips one failing mjsunit test. #

Patch Set 7 : Rebased the patch. #

Patch Set 8 : Updated webkit.status. Skips a slow test on ignition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -37 lines) Patch
M src/heap/heap.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 5 6 1 chunk +2 lines, -31 lines 0 comments Download
M test/webkit/webkit.status View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 35 (15 generated)
mythria
PTAL. Thanks, Mythri
4 years, 9 months ago (2016-03-18 10:52:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809123003/60001
4 years, 9 months ago (2016-03-18 10:58:12 UTC) #4
Yang
On 2016/03/18 10:58:12, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 9 months ago (2016-03-18 11:00:46 UTC) #5
rmcilroy
On 2016/03/18 11:00:46, Yang wrote: > On 2016/03/18 10:58:12, commit-bot: I haz the power wrote: ...
4 years, 9 months ago (2016-03-18 11:16:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 11:49:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809123003/60001
4 years, 9 months ago (2016-03-18 11:59:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12580)
4 years, 9 months ago (2016-03-18 12:02:33 UTC) #12
mythria
Hannes, Could you please look at changes in heap/heap.cc. This cl is to fix failing ...
4 years, 9 months ago (2016-03-18 12:14:45 UTC) #14
Hannes Payer (out of office)
lgtm
4 years, 9 months ago (2016-03-21 09:21:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809123003/60001
4 years, 9 months ago (2016-03-21 09:31:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/11915) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-21 09:32:52 UTC) #19
rmcilroy
Does this also fix the issue with msan on the cctest test-debug tests? If so ...
4 years, 9 months ago (2016-03-21 16:31:57 UTC) #20
mythria
On 2016/03/21 16:31:57, rmcilroy wrote: > Does this also fix the issue with msan on ...
4 years, 9 months ago (2016-03-22 08:45:02 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809123003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809123003/120001
4 years, 9 months ago (2016-03-22 08:45:14 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/4877) v8_win64_rel_ng_triggered on ...
4 years, 9 months ago (2016-03-22 09:08:21 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809123003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809123003/140001
4 years, 9 months ago (2016-03-22 09:52:49 UTC) #27
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 10:12:24 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809123003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809123003/140001
4 years, 9 months ago (2016-03-22 11:02:18 UTC) #32
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 9 months ago (2016-03-22 11:04:41 UTC) #33
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 11:05:30 UTC) #35
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/27338320f450a6d41c1fa2dfeae62d3a1aef3e86
Cr-Commit-Position: refs/heads/master@{#34982}

Powered by Google App Engine
This is Rietveld 408576698