Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 1809113002: ES6: improve performance of ES6 instanceof (Closed)

Created:
4 years, 9 months ago by mvstanton
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@intrinsic-4774-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6: improve performance of ES6 instanceof This CL restores special crankshaft optimizations for instance of when --harmony-instanceof is true. Similar work has to happen for TurboFan. I've added a flag to pile-up the optimizations to be done elsewhere, which will follow over several CLs. R=verwaest@chromium.org, mstarzinger@chromium.org BUG=v8:4447 LOG=n Committed: https://crrev.com/f19ec926003282dcc554bb41641fbdf4eaf4a7fe Cr-Commit-Position: refs/heads/master@{#34930}

Patch Set 1 #

Patch Set 2 : REBASE. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 1 2 chunks +40 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
mvstanton
Hi guys, This turns a walloping 86% regression on EB to 25%. Additional improvements to ...
4 years, 9 months ago (2016-03-17 15:18:01 UTC) #1
Michael Starzinger
LGTM on performance workaround. https://codereview.chromium.org/1809113002/diff/20001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1809113002/diff/20001/src/flag-definitions.h#newcode276 src/flag-definitions.h:276: DEFINE_BOOL(harmony_instanceof_opt, false, "optimize ES6 instanceof ...
4 years, 9 months ago (2016-03-18 15:06:40 UTC) #2
Toon Verwaest
lgtm
4 years, 9 months ago (2016-03-21 10:16:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809113002/20001
4 years, 9 months ago (2016-03-21 10:33:38 UTC) #6
Benedikt Meurer
LGTM (rubberstamped)
4 years, 9 months ago (2016-03-21 11:02:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 11:33:58 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 11:35:23 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f19ec926003282dcc554bb41641fbdf4eaf4a7fe
Cr-Commit-Position: refs/heads/master@{#34930}

Powered by Google App Engine
This is Rietveld 408576698