Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: media/audio/audio_output_device.h

Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Getting rid of OutputDevice interface Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_device.h
diff --git a/media/audio/audio_output_device.h b/media/audio/audio_output_device.h
index 26f711d38aca1ec3ef7143577b8e8e4df3335e78..eceed2e4a029f12876a6929ea78d1f9ea109fe6e 100644
--- a/media/audio/audio_output_device.h
+++ b/media/audio/audio_output_device.h
@@ -75,14 +75,13 @@
#include "media/audio/scoped_task_runner_observer.h"
#include "media/base/audio_renderer_sink.h"
#include "media/base/media_export.h"
-#include "media/base/output_device.h"
+#include "media/base/output_device_info.h"
namespace media {
class MEDIA_EXPORT AudioOutputDevice
: NON_EXPORTED_BASE(public AudioRendererSink),
NON_EXPORTED_BASE(public AudioOutputIPCDelegate),
- NON_EXPORTED_BASE(public OutputDevice),
NON_EXPORTED_BASE(public ScopedTaskRunnerObserver) {
public:
// NOTE: Clients must call Initialize() before using.
@@ -104,11 +103,11 @@ class MEDIA_EXPORT AudioOutputDevice
void Play() override;
void Pause() override;
bool SetVolume(double volume) override;
- OutputDevice* GetOutputDevice() override;
- // OutputDevice implementation
- AudioParameters GetOutputParameters() override;
- OutputDeviceStatus GetDeviceStatus() override;
+ // Returns output device information.
Guido Urdaneta 2016/03/22 15:30:18 This documentation is already in audio_renderer_si
o1ka 2016/03/22 16:13:56 Done.
+ // If the information is not available yet, this method may block until it
+ // becomes available. Must never be called on the IO thread.
+ OutputDeviceInfo GetOutputDeviceInfo() override;
// Methods called on IO thread ----------------------------------------------
// AudioOutputIPCDelegate methods.
@@ -138,11 +137,6 @@ class MEDIA_EXPORT AudioOutputDevice
PLAYING, // Playing back. Can Pause()/Stop().
};
- // Unsupported OutputDevice implementation
- void SwitchOutputDevice(const std::string& device_id,
- const url::Origin& security_origin,
- const SwitchOutputDeviceCB& callback) override;
-
// Methods called on IO thread ----------------------------------------------
// The following methods are tasks posted on the IO thread that need to
// be executed on that thread. They use AudioOutputIPC to send IPC messages
@@ -203,7 +197,7 @@ class MEDIA_EXPORT AudioOutputDevice
bool stopping_hack_;
base::WaitableEvent did_receive_auth_;
- media::AudioParameters output_params_;
+ AudioParameters output_params_;
OutputDeviceStatus device_status_;
DISALLOW_COPY_AND_ASSIGN(AudioOutputDevice);

Powered by Google App Engine
This is Rietveld 408576698