Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: media/base/audio_renderer_mixer_input.cc

Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_renderer_mixer_input.h ('k') | media/base/audio_renderer_mixer_input_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer_mixer_input.cc
diff --git a/media/base/audio_renderer_mixer_input.cc b/media/base/audio_renderer_mixer_input.cc
index e47cbea3845af27576be54424e3485382f27f37a..55dbfc8404f76d012cc8550ce2e45f16f7f0bec0 100644
--- a/media/base/audio_renderer_mixer_input.cc
+++ b/media/base/audio_renderer_mixer_input.cc
@@ -15,7 +15,6 @@ namespace media {
AudioRendererMixerInput::AudioRendererMixerInput(
const GetMixerCB& get_mixer_cb,
const RemoveMixerCB& remove_mixer_cb,
- const GetHardwareParamsCB& get_hardware_params_cb,
const std::string& device_id,
const url::Origin& security_origin)
: started_(false),
@@ -23,7 +22,6 @@ AudioRendererMixerInput::AudioRendererMixerInput(
volume_(1.0f),
get_mixer_cb_(get_mixer_cb),
remove_mixer_cb_(remove_mixer_cb),
- get_hardware_params_cb_(get_hardware_params_cb),
device_id_(device_id),
security_origin_(security_origin),
mixer_(nullptr),
@@ -113,14 +111,14 @@ bool AudioRendererMixerInput::SetVolume(double volume) {
return true;
}
-OutputDevice* AudioRendererMixerInput::GetOutputDevice() {
- return this;
+OutputDeviceInfo AudioRendererMixerInput::GetOutputDeviceInfo() {
+ return mixer_ ? mixer_->GetOutputDeviceInfo() : OutputDeviceInfo();
}
void AudioRendererMixerInput::SwitchOutputDevice(
const std::string& device_id,
const url::Origin& security_origin,
- const SwitchOutputDeviceCB& callback) {
+ const OutputDeviceStatusCB& callback) {
if (!mixer_) {
if (pending_switch_callback_.is_null()) {
pending_switch_callback_ = callback;
@@ -161,22 +159,6 @@ void AudioRendererMixerInput::SwitchOutputDevice(
callback.Run(OUTPUT_DEVICE_STATUS_OK);
}
-AudioParameters AudioRendererMixerInput::GetOutputParameters() {
- if (mixer_)
- return mixer_->GetOutputDevice()->GetOutputParameters();
- return get_hardware_params_cb_.Run(device_id_, security_origin_);
-}
-
-OutputDeviceStatus AudioRendererMixerInput::GetDeviceStatus() {
- if (mixer_)
- return mixer_->GetOutputDevice()->GetDeviceStatus();
-
- if (started_)
- return OUTPUT_DEVICE_STATUS_ERROR_INTERNAL;
-
- return OUTPUT_DEVICE_STATUS_OK;
-}
-
double AudioRendererMixerInput::ProvideInput(AudioBus* audio_bus,
base::TimeDelta buffer_delay) {
// TODO(chcunningham): Delete this conversion and change ProvideInput to more
« no previous file with comments | « media/base/audio_renderer_mixer_input.h ('k') | media/base/audio_renderer_mixer_input_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698