Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice

media/base/output_device_info.cc

Index: media/base/output_device_info.cc
diff --git a/media/base/output_device_info.cc b/media/base/output_device_info.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9c19c6de99dff943d14c8efcae250c4f204d8f77
--- /dev/null
+++ b/media/base/output_device_info.cc
@@ -0,0 +1,42 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[Henrik Grunell, 2016/03/25 10:44:40]

Ditto.

[o1ka, 2016/03/29 13:39:54]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/output_device_info.h"
+
+namespace media {
+
+OutputDeviceInfo::OutputDeviceInfo()
+    : OutputDeviceInfo(OUTPUT_DEVICE_STATUS_ERROR_INTERNAL) {}
+
+OutputDeviceInfo::OutputDeviceInfo(OutputDeviceStatus device_status)
+    : OutputDeviceInfo(std::string(),
+                       device_status,
+                       AudioParameters(AudioParameters::AUDIO_FAKE,

[miu, 2016/03/24 21:32:02]

OOC, why specify the AUDIO_FAKE device here?  Any particular reason why you
don't just use the zero-arg AudioParameters constructor call here?

[o1ka, 2016/03/29 13:39:54]

This is a very good question. Default constructor creates some intentionally
invalid non-serializable paramters. On the other hand, if output device is not
available/not authorized, AudioRendererHost provides us some fake parameters. We
want to be consistent with AudioRendererHost here. I fixed it a little bit. 

+                                       CHANNEL_LAYOUT_NONE,
+                                       0,
+                                       0,
+                                       0)) {}
+
+OutputDeviceInfo::OutputDeviceInfo(const std::string& device_id,
+                                   OutputDeviceStatus device_status,
+                                   const AudioParameters& output_params)
+    : device_id_(device_id),
+      device_status_(device_status),
+      output_params_(output_params) {}
+
+OutputDeviceInfo::OutputDeviceInfo(const OutputDeviceInfo&) = default;
+
+OutputDeviceInfo::~OutputDeviceInfo() {}
+
+OutputDeviceInfo& OutputDeviceInfo::operator=(const OutputDeviceInfo&) =
+    default;
+
+std::string OutputDeviceInfo::AsHumanReadableString() const {
+  std::ostringstream s;
+  s << "device_id: " << device_id() << " device_status: " << device_status()
+    << " output_params: [ " << output_params().AsHumanReadableString() << " ]";
+  return s.str();
+}
+
+}  // namespace media