Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice

media/base/audio_renderer_mixer_input.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/audio_renderer_mixer_input.h"
 
 #include <cmath>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "media/base/audio_renderer_mixer.h"
 
 namespace media {
 
 AudioRendererMixerInput::AudioRendererMixerInput(
     const GetMixerCB& get_mixer_cb,
     const RemoveMixerCB& remove_mixer_cb,
-    const GetHardwareParamsCB& get_hardware_params_cb,
+    const GetOutputDeviceCB& get_output_device_cb,
     const std::string& device_id,
     const url::Origin& security_origin)
     : started_(false),
       playing_(false),
       volume_(1.0f),
       get_mixer_cb_(get_mixer_cb),
       remove_mixer_cb_(remove_mixer_cb),
-      get_hardware_params_cb_(get_hardware_params_cb),
+      get_output_device_cb_(get_output_device_cb),
       device_id_(device_id),
       security_origin_(security_origin),
       mixer_(nullptr),
       callback_(nullptr),
       error_cb_(base::Bind(&AudioRendererMixerInput::OnRenderError,
                            base::Unretained(this))) {}
 
 AudioRendererMixerInput::~AudioRendererMixerInput() {
   DCHECK(!mixer_);
 }
@@ skipping 67 matching lines @@
   mixer_->RemoveMixerInput(params_, this);
   playing_ = false;
 }
 
 bool AudioRendererMixerInput::SetVolume(double volume) {
   volume_ = volume;
   return true;
 }
 
 OutputDevice* AudioRendererMixerInput::GetOutputDevice() {
-  return this;
+  return mixer_ ? mixer_->GetOutputDevice()
+                : get_output_device_cb_.Run(device_id_, security_origin_);

[Guido Urdaneta, 2016/03/17 17:38:24]

Shouldn't this one return nullptr when there is no mixer?

GetOutputDevice() does not give ownership of the returned OD. Is it possible
that the OD returned by get_output_device_cb_.Run() is a new one that will leak?

[o1ka, 2016/03/18 10:45:40]

Of cause we need to make sure it does not leak ;) GetOutputDevice does not pass
ownership. Removing this code, since it's a part of a future CL.

 }
 
 void AudioRendererMixerInput::SwitchOutputDevice(
     const std::string& device_id,
     const url::Origin& security_origin,
     const SwitchOutputDeviceCB& callback) {
   if (!mixer_) {
     if (pending_switch_callback_.is_null()) {
       pending_switch_callback_ = callback;
       pending_switch_device_id_ = device_id;
@@ skipping 26 matching lines @@
   mixer_ = new_mixer;
   mixer_->AddErrorCallback(error_cb_);
   started_ = true;
 
   if (was_playing)
     Play();
 
   callback.Run(OUTPUT_DEVICE_STATUS_OK);
 }
 
-AudioParameters AudioRendererMixerInput::GetOutputParameters() {
-  if (mixer_)
-    return mixer_->GetOutputDevice()->GetOutputParameters();
-  return get_hardware_params_cb_.Run(device_id_, security_origin_);
-}
-
-OutputDeviceStatus AudioRendererMixerInput::GetDeviceStatus() {
-  if (mixer_)
-    return mixer_->GetOutputDevice()->GetDeviceStatus();
-
-  if (started_)
-    return OUTPUT_DEVICE_STATUS_ERROR_INTERNAL;
-
-  return OUTPUT_DEVICE_STATUS_OK;
-}
-
 double AudioRendererMixerInput::ProvideInput(AudioBus* audio_bus,
                                              base::TimeDelta buffer_delay) {
   // TODO(chcunningham): Delete this conversion and change ProvideInput to more
   // precisely describe delay as a count of frames delayed instead of TimeDelta.
   // See http://crbug.com/587522.
   uint32_t frames_delayed = std::round(buffer_delay.InMicroseconds() /
                                        params_.GetMicrosecondsPerFrame());
 
   int frames_filled = callback_->Render(audio_bus, frames_delayed, 0);
 
   // AudioConverter expects unfilled frames to be zeroed.
   if (frames_filled < audio_bus->frames()) {
     audio_bus->ZeroFramesPartial(
         frames_filled, audio_bus->frames() - frames_filled);
   }
 
   return frames_filled > 0 ? volume_ : 0;
 }
 
 void AudioRendererMixerInput::OnRenderError() {
   callback_->OnRenderError();
 }
 
 }  // namespace media