Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1809033002: Pasting \n into an empty TEXTAREA should set the caret after the \n. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pasting \n into an empty TEXTAREA should set the caret after the \n. This didn't work because isStartOfParagraph(endOfInsertedContent) was true and <br> wasn't added. This CL moves HTMLTextFormControlElement handling code earlier, and makes it cover this case. BUG=380471 Committed: https://crrev.com/fe0e7d280a97e68f43f5c66beaf4521030572912 Cr-Commit-Position: refs/heads/master@{#381685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-paste-newline.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
yosin@, would you review this please?
4 years, 9 months ago (2016-03-17 08:42:31 UTC) #2
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-17 09:52:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809033002/1
4 years, 9 months ago (2016-03-17 09:53:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 10:20:48 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 10:22:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe0e7d280a97e68f43f5c66beaf4521030572912
Cr-Commit-Position: refs/heads/master@{#381685}

Powered by Google App Engine
This is Rietveld 408576698