Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2294)

Issue 1809013003: Move DartObject into the public API (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -159 lines) Patch
A pkg/analyzer/lib/dart/constant/value.dart View 1 chunk +159 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/element/element.dart View 4 chunks +13 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 3 chunks +3 lines, -140 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-18 00:07:39 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-18 00:09:20 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-18 14:42:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50c913170205c4aa6672c7071396cd688cdedc17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698