Issue 18090004: Add regression test for r24720.

Issue 18090004: Add regression test for r24720. (Closed)

Created:
7 years, 5 months ago by Johnni Winther

Modified:
7 years, 5 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add regression test for r24720. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=24780

Patch Set 2 : Updated cf. comment. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	A +	tests/language/regress_r24720_test.dart	View		1 chunk	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/18090004/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/18090004/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode1350 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1350: // If [inlinedFromElement] is generative constructor [superclass] is ...

7 years, 5 months ago (2013-07-05 06:31:34 UTC) #2

Johnni Winther

https://codereview.chromium.org/18090004/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/18090004/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode1350 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1350: // If [inlinedFromElement] is generative constructor [superclass] is a ...

7 years, 5 months ago (2013-07-05 07:11:24 UTC) #3

Johnni Winther

7 years, 5 months ago (2013-07-05 07:12:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24780 (presubmit successful).

Expand Messages | Collapse Messages