Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1808993002: [ios] Removed UIWebView JS evaluation code. (Closed)

Created:
4 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 9 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed UIWebView JS evaluation code. BUG=579697 Committed: https://crrev.com/281c2845e0dbcbee2aad4227c40556192ff2872a Cr-Commit-Position: refs/heads/master@{#381743}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -34 lines) Patch
M ios/web/public/web_state/js/crw_js_injection_evaluator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/ui/web_view_js_utils.h View 2 chunks +3 lines, -17 lines 0 comments Download
M ios/web/web_state/ui/web_view_js_utils.mm View 3 chunks +4 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808993002/1
4 years, 9 months ago (2016-03-17 06:01:13 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 06:33:31 UTC) #4
Eugene But (OOO till 7-30)
4 years, 9 months ago (2016-03-17 13:36:39 UTC) #6
Jackie Quinn
lgtm, with question about future work. https://codereview.chromium.org/1808993002/diff/1/ios/web/web_state/ui/web_view_js_utils.mm File ios/web/web_state/ui/web_view_js_utils.mm (right): https://codereview.chromium.org/1808993002/diff/1/ios/web/web_state/ui/web_view_js_utils.mm#newcode16 ios/web/web_state/ui/web_view_js_utils.mm:16: NSString* StringResultFromWKResult(id result) ...
4 years, 9 months ago (2016-03-17 17:06:43 UTC) #7
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/1808993002/diff/1/ios/web/web_state/ui/web_view_js_utils.mm File ios/web/web_state/ui/web_view_js_utils.mm (right): https://codereview.chromium.org/1808993002/diff/1/ios/web/web_state/ui/web_view_js_utils.mm#newcode16 ios/web/web_state/ui/web_view_js_utils.mm:16: NSString* StringResultFromWKResult(id result) { On 2016/03/17 17:06:43, Jackie ...
4 years, 9 months ago (2016-03-17 17:19:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808993002/20001
4 years, 9 months ago (2016-03-17 17:19:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 18:02:50 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 18:04:12 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/281c2845e0dbcbee2aad4227c40556192ff2872a
Cr-Commit-Position: refs/heads/master@{#381743}

Powered by Google App Engine
This is Rietveld 408576698