media: Add MediaDrmBridgeCdmContext.

media/base/cdm_context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_CDM_CONTEXT_H_
 #define MEDIA_BASE_CDM_CONTEXT_H_
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "media/base/media_export.h"
 
 namespace media {
 
 class Decryptor;
 
-// An interface representing the context that a media pipeline needs from a
+// An interface representing the context that a media player needs from a
 // content decryption module (CDM) to decrypt (and decode) encrypted buffers.
 // Only used for implementing SetCdm().
+//
+// There are CDMs that support neither Decryptor nor CDM ID, but use other ways

[ddorwin, 2016/03/21 21:40:25]

We should probably move this to the new subclass as an explanation of how it
works. Changing the comments (and thus definitions) below will make this
behavior not so unexpected.

[xhwang, 2016/03/22 17:08:32]

Done.

+// to connect the CDM with a media player. In this case, the CdmContext

[ddorwin, 2016/03/21 18:06:09]

Is there a reason that the CDM ID couldn't be used to obtain the MediaCrypto? I
guess we'd have to do a lookup in a manager, which wouldn't be ideal, but
neither is casting.

If that's not ideal, should we even support CDM ID? Any implementation needing
to use an ID could implement it. The primary argument against this is likely
that we still use the ID in the renderer process (right?).

Using the same type for very different reasons in different processes makes
improvements here difficult. We're doing/allowing some things very specific to
the privileged process usage of this interface that don't make sense on the
renderer side.

If we make even AesDecryptor a Mojo service (implemented in the renderer) I
wonder if we even need these interfaces in the renderer side once we switch all
platforms to Mojo. In the meantime, I wonder if we shouldn't have different
objects, starting with PlatformMediaKeys : public MediaKeys, which would allow
different CdmContexts to be returned.

Perhaps we should formalize the pattern recommended here by having a void*
returning method, though that might not be any better.

Alternatively, if we think a CetFooReadyCB might be useful, we could add such a
method that takes a void* and let the implementation do the casting. It seems
better for the casting to be clearly intended that way and to be done by the
implementation than to put that responsibility on the caller/user of the API.

[xhwang, 2016/03/22 17:08:32]

Acknowledged.

+// implementation should add APIs to support such connection. The media player
+// should cast the CdmContext to the correct type to access such APIs.

[ddorwin, 2016/03/21 18:06:09]

It seems strange to provide such recommendations in an API definition,
especially since there are some subtleties, such as ensuring that is the only
possible type.

[xhwang, 2016/03/22 17:08:32]

Done.

 class MEDIA_EXPORT CdmContext {
  public:
   // Indicates an invalid CDM ID. See GetCdmId() for details.
   static const int kInvalidCdmId = 0;
 
   virtual ~CdmContext();
 
   // Gets the Decryptor object associated with the CDM. Returns nullptr if the
   // CDM does not support a Decryptor. Must not return nullptr if GetCdmId()

[ddorwin, 2016/03/21 18:06:09]

This is not true in the new child.

[ddorwin, 2016/03/21 21:40:25]

As discussed, we should instead describe when each of these are valid. That will
allow the new subclass not to be an exception.

[xhwang, 2016/03/22 17:08:32]

Done.

[xhwang, 2016/03/22 17:08:32]

Done.

   // returns kInvalidCdmId. The returned object is only guaranteed to be valid
   // during the CDM's lifetime.
   virtual Decryptor* GetDecryptor() = 0;
 
   // Returns an ID that identifies a CDM, or kInvalidCdmId. The interpretation
   // is implementation-specific; current implementations use the ID to locate a
   // remote CDM in a different process. The return value will not be
   // kInvalidCdmId if GetDecryptor() returns nullptr.

[ddorwin, 2016/03/21 18:06:09]

ditto

[xhwang, 2016/03/22 17:08:32]

Done.

   virtual int GetCdmId() const = 0;
 
  protected:
   CdmContext();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CdmContext);
 };
 
 // Callback to notify that the CdmContext has been completely attached to
 // the media pipeline. Parameter indicates whether the operation succeeded.
 typedef base::Callback<void(bool)> CdmAttachedCB;
 
 // A dummy implementation of CdmAttachedCB.
 MEDIA_EXPORT void IgnoreCdmAttached(bool success);
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_CDM_CONTEXT_H_