net/cert/cert_verify_proc_unittest.cc - Issue 1808963004: Adding macro to enable changing SSL library (Part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_unittest.cc

Issue 1808963004: Adding macro to enable changing SSL library (Part 1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove remoting_nacl change. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/cert_verify_proc_unittest.cc

diff --git a/net/cert/cert_verify_proc_unittest.cc b/net/cert/cert_verify_proc_unittest.cc

index be7f4d1b3b3250e7b05a804948e95b824bd80e16..1202d049282eda930a0e9bf7e0cfd6fb96e0bda8 100644

--- a/net/cert/cert_verify_proc_unittest.cc

+++ b/net/cert/cert_verify_proc_unittest.cc

@@ -245,7 +245,7 @@ TEST_F(CertVerifyProcTest, PaypalNullCertParsing) {

NULL,

empty_cert_list_,

&verify_result);

-#if defined(USE_NSS_CERTS) || defined(OS_IOS) || defined(OS_ANDROID)

+#if defined(USE_NSS_VERIFIER) || defined(OS_ANDROID)

EXPECT_EQ(ERR_CERT_COMMON_NAME_INVALID, error);

#else

// TOOD(bulach): investigate why macosx and win aren't returning

@@ -255,7 +255,7 @@ TEST_F(CertVerifyProcTest, PaypalNullCertParsing) {

// Either the system crypto library should correctly report a certificate

// name mismatch, or our certificate blacklist should cause us to report an

// invalid certificate.

-#if defined(USE_NSS_CERTS) || defined(OS_WIN) || defined(OS_IOS)

+#if defined(USE_NSS_VERIFIER) || defined(OS_WIN)

EXPECT_TRUE(verify_result.cert_status &

(CERT_STATUS_COMMON_NAME_INVALID | CERT_STATUS_INVALID));

#endif

« no previous file with comments | « net/cert/cert_verify_proc.cc ('k') | net/cert/ev_root_ca_metadata.h » ('j') | no next file with comments »