Adding macro to enable changing SSL library (Part 1)

crypto/nss_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/nss_util.h"
 
 #include <nss.h>
 #include <pk11pub.h>
 #include <plarena.h>
 #include <prerror.h>
@@ skipping 697 matching lines @@
     // Use the system certificate store, so initialize NSS without database.
     nodb_init = true;
 #endif
 
     if (nodb_init) {
       status = NSS_NoDB_Init(NULL);
       if (status != SECSuccess) {
         CrashOnNSSInitFailure();
         return;
       }
-#if defined(OS_IOS)
+#if defined(OS_IOS) && !defined(USE_OPENSSL)

[davidben, 2016/03/17 19:48:08]

Shouldn't OS_IOS && USE_OPENSSL be impossible in this file?

[svaldez, 2016/03/17 20:04:18]

Done.

       root_ = InitDefaultRootCerts();
-#endif  // defined(OS_IOS)
+#endif  // defined(OS_IOS) && !defined(USE_OPENSSL)
     } else {
 #if defined(USE_NSS_CERTS)
       base::FilePath database_dir = GetInitialConfigDirectory();
       if (!database_dir.empty()) {
         // This duplicates the work which should have been done in
         // EarlySetupForNSSInit. However, this function is idempotent so
         // there's no harm done.
         UseLocalCacheOfNSSDatabaseIfNFS(database_dir);
 
         // Initialize with a persistent database (likely, ~/.pki/nssdb).
@@ skipping 65 matching lines @@
     }
 
     SECStatus status = NSS_Shutdown();
     if (status != SECSuccess) {
       // We VLOG(1) because this failure is relatively harmless (leaking, but
       // we're shutting down anyway).
       VLOG(1) << "NSS_Shutdown failed; see http://crbug.com/4609";
     }
   }
 
-#if defined(USE_NSS_CERTS) || defined(OS_IOS)
+#if defined(USE_NSS_VERIFIER)

[davidben, 2016/03/17 19:48:08]

Are there any cases where this ifdef is false and we build this? (I probably
should have just removed this earlier.)

[svaldez, 2016/03/17 20:04:18]

Done.

   // Load nss's built-in root certs.
   SECMODModule* InitDefaultRootCerts() {
     SECMODModule* root = LoadModule("Root Certs", "libnssckbi.so", NULL);
     if (root)
       return root;
 
     // Aw, snap.  Can't find/load root cert shared library.
     // This will make it hard to talk to anybody via https.
     // TODO(mattm): Re-add the NOTREACHED here when crbug.com/310972 is fixed.
     return NULL;
@@ skipping 203 matching lines @@
   return time.ToInternalValue() - base::Time::UnixEpoch().ToInternalValue();
 }
 
 #if !defined(OS_CHROMEOS)
 PK11SlotInfo* GetPersistentNSSKeySlot() {
   return g_nss_singleton.Get().GetPersistentNSSKeySlot();
 }
 #endif
 
 }  // namespace crypto