Handlify JSObject::SetPrototype method.

Handlify JSObject::SetPrototype method.

R=rossberg@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=15455

[rossberg, 2013-07-02 12:08:01]

LGTM with comments

https://codereview.chromium.org/18089024/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/18089024/diff/1/src/objects.cc#newcode11036
src/objects.cc:11036: return Handle<Map>(Map::cast(result));
Don't forget to pass the isolate.

https://codereview.chromium.org/18089024/diff/1/src/objects.cc#newcode11054
src/objects.cc:11054: Handle<FixedArray> cache(map->GetPrototypeTransitions());
Pass the isolate.

https://codereview.chromium.org/18089024/diff/1/src/objects.cc#newcode11355
src/objects.cc:11355: real_receiver =
Handle<JSObject>(JSObject::cast(current_proto));
Pass the isolate. Also, you can use handle(..., isolate) here to avoid the
duplicate type.

https://codereview.chromium.org/18089024/diff/1/src/objects.cc#newcode11361
src/objects.cc:11361: Handle<Map> map(real_receiver->map());
Pass the isolate.

[Michael Starzinger, 2013-07-02 15:20:15]

Thanks. Landing.

https://codereview.chromium.org/18089024/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/18089024/diff/1/src/objects.cc#newcode11036
src/objects.cc:11036: return Handle<Map>(Map::cast(result));
On 2013/07/02 12:08:01, rossberg wrote:
> Don't forget to pass the isolate.

As dicussed offline, it's not needed to pass the isolate here, as the
constructor will use map->GetIsolate() to get to the isolate efficiently.

https://codereview.chromium.org/18089024/diff/1/src/objects.cc#newcode11054
src/objects.cc:11054: Handle<FixedArray> cache(map->GetPrototypeTransitions());
On 2013/07/02 12:08:01, rossberg wrote:
> Pass the isolate.

Likeiwse.

https://codereview.chromium.org/18089024/diff/1/src/objects.cc#newcode11355
src/objects.cc:11355: real_receiver =
Handle<JSObject>(JSObject::cast(current_proto));
On 2013/07/02 12:08:01, rossberg wrote:
> Pass the isolate. Also, you can use handle(..., isolate) here to avoid the
> duplicate type.

Done, switched to handle(..., isolate) to avoid type dupliction.

https://codereview.chromium.org/18089024/diff/1/src/objects.cc#newcode11361
src/objects.cc:11361: Handle<Map> map(real_receiver->map());
On 2013/07/02 12:08:01, rossberg wrote:
> Pass the isolate.

Likewise.

[Michael Starzinger, 2013-07-02 15:33:05]

Committed patchset #1 manually as r15455 (presubmit successful).