Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Side by Side Diff: runtime/vm/intermediate_language.h

Issue 18089019: Fixed crash in EqualityCompareInstr::IsCheckedStrictEqual : update unary_ic_data_ if ic_data_ is se… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_INTERMEDIATE_LANGUAGE_H_ 5 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
6 #define VM_INTERMEDIATE_LANGUAGE_H_ 6 #define VM_INTERMEDIATE_LANGUAGE_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/ast.h" 9 #include "vm/ast.h"
10 #include "vm/growable_array.h" 10 #include "vm/growable_array.h"
(...skipping 2828 matching lines...) Expand 10 before | Expand all | Expand 10 after
2839 } 2839 }
2840 2840
2841 DECLARE_INSTRUCTION(EqualityCompare) 2841 DECLARE_INSTRUCTION(EqualityCompare)
2842 virtual CompileType ComputeType() const; 2842 virtual CompileType ComputeType() const;
2843 virtual bool RecomputeType(); 2843 virtual bool RecomputeType();
2844 2844
2845 const ICData* ic_data() const { return ic_data_; } 2845 const ICData* ic_data() const { return ic_data_; }
2846 bool HasICData() const { 2846 bool HasICData() const {
2847 return (ic_data() != NULL) && !ic_data()->IsNull(); 2847 return (ic_data() != NULL) && !ic_data()->IsNull();
2848 } 2848 }
2849 void set_ic_data(const ICData* value) { ic_data_ = value; } 2849 void set_ic_data(const ICData* value) {
2850 ic_data_ = value;
2851 if (HasICData()) {
2852 unary_ic_data_ = &ICData::ZoneHandle(ic_data_->AsUnaryClassChecks());
2853 }
2854 }
2850 2855
2851 // Receiver class id is computed from collected ICData. 2856 // Receiver class id is computed from collected ICData.
2852 void set_receiver_class_id(intptr_t value) { receiver_class_id_ = value; } 2857 void set_receiver_class_id(intptr_t value) { receiver_class_id_ = value; }
2853 intptr_t receiver_class_id() const { return receiver_class_id_; } 2858 intptr_t receiver_class_id() const { return receiver_class_id_; }
2854 2859
2855 bool IsInlinedNumericComparison() const { 2860 bool IsInlinedNumericComparison() const {
2856 return (receiver_class_id() == kDoubleCid) 2861 return (receiver_class_id() == kDoubleCid)
2857 || (receiver_class_id() == kMintCid) 2862 || (receiver_class_id() == kMintCid)
2858 || (receiver_class_id() == kSmiCid); 2863 || (receiver_class_id() == kSmiCid);
2859 } 2864 }
(...skipping 3607 matching lines...) Expand 10 before | Expand all | Expand 10 after
6467 ForwardInstructionIterator* current_iterator_; 6472 ForwardInstructionIterator* current_iterator_;
6468 6473
6469 private: 6474 private:
6470 DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor); 6475 DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
6471 }; 6476 };
6472 6477
6473 6478
6474 } // namespace dart 6479 } // namespace dart
6475 6480
6476 #endif // VM_INTERMEDIATE_LANGUAGE_H_ 6481 #endif // VM_INTERMEDIATE_LANGUAGE_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698