Swap main menu with app-specific menu when app window focused.

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 49 matching lines @@
 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"
 #include "chrome/browser/ui/cocoa/task_manager_mac.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/cloud_print/cloud_print_class_mac.h"
+#include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/mac/app_mode_common.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/service_messages.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/plugin_service.h"
@@ skipping 1223 matching lines @@
   [self performSelector:@selector(delayedScreenParametersUpdate)
              withObject:nil
              afterDelay:0];
 }
 
 - (void)delayedScreenParametersUpdate {
   FOR_EACH_OBSERVER(ui::WorkAreaWatcherObserver, workAreaChangeObservers_,
       WorkAreaChanged());
 }
 
+- (void)setMenuBarToApp:(NSString*)app_id
+              withTitle:(NSString*)title {
+  NSMenu* mainMenu = [NSApp mainMenu];
+
+  for (NSMenuItem* item in [mainMenu itemArray])
+    [item setHidden:YES];
+
+  NSMenuItem* itemForApp = [mainMenu itemWithTitle:app_id];
+  if (!itemForApp) {
+    NSMenuItem* appMenuItem = [[NSMenuItem alloc]

[tapted, 2013/06/28 04:09:43]

there's a memory leak here ;) - you need

scoped_nsobject<NSMenuItem> appMenuItem(
    [[NSMenuItem alloc] initWithTitle:
                                      /* etc */]);

[jackhou1, 2013/07/04 01:57:55]

Done.

+        initWithTitle:app_id
+               action:@selector(itemSelected:)

[tapted, 2013/06/28 04:09:43]

I think the action can be `nil`, since we aren't setting a target.

[jackhou1, 2013/07/04 01:57:55]

Done.

+        keyEquivalent:@""];
+    NSMenu* appMenu = [[NSMenu alloc] initWithTitle:title];

[tapted, 2013/06/28 04:09:43]

scoped_nsobject<NSMenu>

[jackhou1, 2013/07/04 01:57:55]

Done.

+    [appMenuItem setSubmenu:appMenu];
+    [mainMenu addItem:appMenuItem];
+  }
+  [itemForApp setHidden:NO];

[tapted, 2013/06/28 04:09:43]

maybe in an else {? you're not re-assigning, so itemForApp will always be null
if !else

[jackhou1, 2013/07/04 01:57:55]

Done.

+}
+
+- (void)setMenuBarToChrome {
+  NSMenu* mainMenu = [NSApp mainMenu];

[tapted, 2013/06/28 04:09:43]

nit: probably don't need this temporary

[jackhou1, 2013/07/04 01:57:55]

Done.

+  for (NSMenuItem* item in [mainMenu itemArray]) {
+    const std::string& title = base::SysNSStringToUTF8([item title]);
+    [item setHidden:extensions::Extension::IdIsValid(title)];

[tapted, 2013/06/28 04:09:43]

hm.. this feels a bit odd.. Swapping out [NSApp mainMenu] probably won't work --
background things in Chrome seem to depend on it. But maybe something more
certain like simply storing a scoped_nsobject<NSMenuItem> appMenuItem_ data
member.

And I don't think we should keep them around -- just remove, and recreate/re-add
each time the app is activated.

Then this function is

if (!appMenuItem_)
  return;

[[NSApp mainMenu] removeItem:appMenuItem_];
appMenuItem_.reset();
for (..) 
  setHidden:NO

WDYT? You probably won't even need to pass in app_id then.

[jackhou1, 2013/07/04 01:57:55]

Done.

+  }
+}
+
 @end  // @implementation AppController
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac