Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Issue 1808853002: Move UnicodeRangeSet to platform/fonts (Closed)

Created:
4 years, 9 months ago by drott
Modified:
4 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move UnicodeRangeSet to platform/fonts Preparation for using UnicodeRangeSet in both CSSFontFace and HarfBuzzFace for sharing character range set restriction information. BUG=583450 R=eae Committed: https://crrev.com/cb99415fdae9271a608bdf01a30add3dfece83e8 Cr-Commit-Position: refs/heads/master@{#381536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -245 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.h View 3 chunks +1 line, -37 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/core/css/CSSFontFaceTest.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/fonts/UnicodeRangeSet.h View 2 chunks +34 lines, -30 lines 0 comments Download
A third_party/WebKit/Source/platform/fonts/UnicodeRangeSet.cpp View 1 chunk +93 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp View 5 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
drott
4 years, 9 months ago (2016-03-16 19:31:06 UTC) #2
eae
LGTM
4 years, 9 months ago (2016-03-16 19:40:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808853002/1
4 years, 9 months ago (2016-03-16 19:40:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:54:09 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:56:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb99415fdae9271a608bdf01a30add3dfece83e8
Cr-Commit-Position: refs/heads/master@{#381536}

Powered by Google App Engine
This is Rietveld 408576698