Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1808823002: Revert of Assembler changes for enabling GrowHeap in Wasm (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Assembler changes for enabling GrowHeap in Wasm (patchset #13 id:260001 of https://codereview.chromium.org/1759873002/ ) Reason for revert: Breaks compile: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/7740 Probably had outdated tryjobs Original issue's description: > Assembler changes for enabling GrowHeap in Wasm > - New RelocInfo mode WASM_MEMORY_REFERENCE as a marker for wasm code objects that need to be relocated on a heap change > - RelocInfo mode recorded for immediates that use the memory buffer as base > - Tests to verify address patching works > > BUG= > > Committed: https://crrev.com/cc815b69c17da368107ed77306a5bb161170c834 > Cr-Commit-Position: refs/heads/master@{#34831} TBR=titzer@chromium.org,yangguo@chromium.org,bradnelson@chromium.org,bradnelson@google.com,marija.antic@imgtec.com,gdeepti@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/894bc100c3d575e061bfd476bb27fad548a942f6 Cr-Commit-Position: refs/heads/master@{#34832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -483 lines) Patch
M src/arm/assembler-arm-inl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/assembler.h View 4 chunks +1 line, -11 lines 0 comments Download
M src/assembler.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32-inl.h View 3 chunks +0 lines, -22 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M test/cctest/cctest.gyp View 4 chunks +4 lines, -8 lines 0 comments Download
D test/cctest/test-run-wasm-relocation-arm.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D test/cctest/test-run-wasm-relocation-arm64.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D test/cctest/test-run-wasm-relocation-ia32.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D test/cctest/test-run-wasm-relocation-x64.cc View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Assembler changes for enabling GrowHeap in Wasm
4 years, 9 months ago (2016-03-16 17:27:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808823002/1
4 years, 9 months ago (2016-03-16 17:27:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 17:27:53 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:28:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/894bc100c3d575e061bfd476bb27fad548a942f6
Cr-Commit-Position: refs/heads/master@{#34832}

Powered by Google App Engine
This is Rietveld 408576698