Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1808793002: Use cached compressed certs if available to reduce load of compressing certs. Flag protected by qui… (Closed)

Created:
4 years, 9 months ago by fnk
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use cached compressed certs if available to reduce load of compressing certs. Flag protected by quic_use_cached_compressed_certs. Merge internal change: 116579250. R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -10 lines) Patch
M net/quic/crypto/crypto_server_test.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 5 chunks +18 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 7 chunks +38 lines, -6 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 3 chunks +108 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 1 comment Download

Dependent Patchsets:

Issue 1809703002 Patch 1

Messages

Total messages: 7 (2 generated)
fnk
4 years, 9 months ago (2016-03-16 16:46:40 UTC) #1
Ryan Hamilton
lgtm
4 years, 9 months ago (2016-03-16 18:22:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808793002/1
4 years, 9 months ago (2016-03-16 19:17:25 UTC) #4
Ryan Hamilton
https://codereview.chromium.org/1808793002/diff/1/net/quic/quic_flags.cc File net/quic/quic_flags.cc (right): https://codereview.chromium.org/1808793002/diff/1/net/quic/quic_flags.cc#newcode139 net/quic/quic_flags.cc:139: bool FLAGS_quic_use_cached_compressed_certs = false; I think this should be ...
4 years, 9 months ago (2016-03-16 20:28:00 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:53:40 UTC) #7 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698