Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1808743003: Allow SkGpuDevice::drawSprite to handle subset SkBitmaps (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow SkGpuDevice::drawSprite to handle subset SkBitmaps With the upcoming switch to SkSpecialImage in the blur image filter, it is possible for drawSprite calls to use an SkBitmap with an offset (e.g., a blur image filter with a cropRect and 0 blur radii). This simply updates the drawSprite code path to be origin aware. This is calved off of: https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1808743003 Committed: https://skia.googlesource.com/skia/+/e1849d14b9b50ba0346840f74adfcd7052603b43

Patch Set 1 #

Patch Set 2 : allos SkGpuDevice::drawSprite to handle subset SkBitmaps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/gpu/SkGpuDevice.cpp View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
robertphillips
4 years, 9 months ago (2016-03-16 15:54:36 UTC) #4
robertphillips
ping
4 years, 9 months ago (2016-03-17 14:10:20 UTC) #6
bsalomon
lgtm
4 years, 9 months ago (2016-03-17 14:47:13 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808743003/20001
4 years, 9 months ago (2016-03-17 15:12:42 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 15:23:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808743003/20001
4 years, 9 months ago (2016-03-17 15:25:42 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 15:26:41 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e1849d14b9b50ba0346840f74adfcd7052603b43

Powered by Google App Engine
This is Rietveld 408576698