Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1808743002: Provide GpuPreferences to content gpu client hook (Closed)

Created:
4 years, 9 months ago by kcwu
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide GpuPreferences to content gpu client hook BUG=b/27687678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M content/gpu/gpu_child_thread.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/public/gpu/content_gpu_client.h View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
kcwu
Because crrev.com/1745903002 needs GpuPreferences to create VDA, add GpuPreferences to gpu hook as well. This ...
4 years, 9 months ago (2016-03-21 09:13:23 UTC) #2
owenlin_google
lgtm
4 years, 9 months ago (2016-03-21 09:17:59 UTC) #4
kcwu
@jam, please owner review. Let me know if you want this CL merged into crrev.com/1641353003. ...
4 years, 9 months ago (2016-03-21 09:21:50 UTC) #5
jam
4 years, 9 months ago (2016-03-21 14:49:55 UTC) #6 
On 2016/03/21 09:21:50, kcwu wrote:
> @jam, please owner review.
> 
> Let me know if you want this CL merged into crrev.com/1641353003.
> 
> Thanks

yes, generally we avoid adding content public apis in isolation because then one
can't see how they're used or if there's another way of doing this.

Powered by Google App Engine
This is Rietveld 408576698