[iOS] Fix ios_web_shell to build with gn.

[iOS] Fix ios_web_shell to build with gn.

Add a new template bundle_data_xib that compile a xib or storyboard
file and declare a bundle_data target with the compilation output.

Add bundle_data targets required to get ios_web_shell to build and
run in the simulator.

BUG=297668, 546283
Committed: https://crrev.com/f33a28da1492886771cefe133372077b762a9077
Cr-Commit-Position: refs/heads/master@{#383295}

[sdefresne, 2016-03-16 18:32:59]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-03-16 18:33:00]

Please take a look.

[Dirk Pranke, 2016-03-16 22:00:17]

lgtm

https://codereview.chromium.org/1808733003/diff/1/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/1808733003/diff/1/build/config/ios/rules.gni#...
build/config/ios/rules.gni:206: _target_name = target_name
why bother with _target_name here?

[sdefresne, 2016-03-17 17:53:14]

Thank you for the review.

https://codereview.chromium.org/1808733003/diff/1/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/1808733003/diff/1/build/config/ios/rules.gni#...
build/config/ios/rules.gni:206: _target_name = target_name
I want the following:

  ${target_name} -> ${target_name}_compile_xib

And limit the dependencies so that only ${target_name} can depends on
${target_name}_compile_xib. Since "target_name" is a "magic" variable in gn, I
have to make a copy, as it is overwritten by the name of the target when
resolving any target scope. The alternative is to not limit visibility, but I'm
a partisan of always using the most restricted visibility possible.

See tools/gn/functions.cc, in particular the function FillTargetBlockScope,
you'll see this at the bottom of the function:

  // Set the target name variable to the current target, and mark it used
  // because we don't want to issue an error if the script ignores it.
  const base::StringPiece target_name("target_name");
  block_scope->SetValue(target_name, Value(function, args[0].string_value()),
                        function);
  block_scope->MarkUsed(target_name);

This is the magic I was referring to.

[Dirk Pranke, 2016-03-18 02:19:59]

https://codereview.chromium.org/1808733003/diff/1/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/1808733003/diff/1/build/config/ios/rules.gni#...
build/config/ios/rules.gni:206: _target_name = target_name
On 2016/03/17 17:53:14, sdefresne wrote:
> I want the following:
> 
>   ${target_name} -> ${target_name}_compile_xib
> 
> And limit the dependencies so that only ${target_name} can depends on
> ${target_name}_compile_xib. Since "target_name" is a "magic" variable in gn, I
> have to make a copy, as it is overwritten by the name of the target when
> resolving any target scope. The alternative is to not limit visibility, but
I'm
> a partisan of always using the most restricted visibility possible.
> 
> See tools/gn/functions.cc, in particular the function FillTargetBlockScope,
> you'll see this at the bottom of the function:
> 
>   // Set the target name variable to the current target, and mark it used
>   // because we don't want to issue an error if the script ignores it.
>   const base::StringPiece target_name("target_name");
>   block_scope->SetValue(target_name, Value(function, args[0].string_value()),
>                         function);
>   block_scope->MarkUsed(target_name);
> 
> This is the magic I was referring to.

Ah, right. I forgot about this. Sorry!

[sdefresne, 2016-03-25 16:36:30]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-03-25 16:36:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1808733003/#ps20001
(title: "Rebase on origin/master")

[commit-bot: I haz the power, 2016-03-25 16:36:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808733003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808733003/20001

[commit-bot: I haz the power, 2016-03-25 17:10:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-25 17:11:48]

Description was changed from

==========
[iOS] Fix ios_web_shell to build with gn.

Add a new template bundle_data_xib that compile a xib or storyboard
file and declare a bundle_data target with the compilation output.

Add bundle_data targets required to get ios_web_shell to build and
run in the simulator.

BUG=297668,546283
==========

to

==========
[iOS] Fix ios_web_shell to build with gn.

Add a new template bundle_data_xib that compile a xib or storyboard
file and declare a bundle_data target with the compilation output.

Add bundle_data targets required to get ios_web_shell to build and
run in the simulator.

BUG=297668,546283

Committed: https://crrev.com/f33a28da1492886771cefe133372077b762a9077
Cr-Commit-Position: refs/heads/master@{#383295}
==========

[commit-bot: I haz the power, 2016-03-25 17:11:49]

Patchset 2 (id:??) landed as
https://crrev.com/f33a28da1492886771cefe133372077b762a9077
Cr-Commit-Position: refs/heads/master@{#383295}