Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1808733002: Introduces a BranchIf helper in the CodeStubAssembler. (Closed)

Created:
4 years, 9 months ago by epertoso
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduces a BranchIf helper in the CodeStubAssembler. BUG= Committed: https://crrev.com/06832bdcd26f8ce10b67a9052517918e0075a8d7 Cr-Commit-Position: refs/heads/master@{#34931}

Patch Set 1 #

Patch Set 2 : Update. #

Patch Set 3 : Update. #

Patch Set 4 : Update. #

Patch Set 5 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -164 lines) Patch
M src/compiler/code-stub-assembler.h View 1 2 3 2 chunks +69 lines, -63 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 2 3 1 chunk +4 lines, -101 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
epertoso
4 years, 9 months ago (2016-03-16 13:31:44 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808733002/1
4 years, 9 months ago (2016-03-16 13:32:04 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15318) v8_linux64_avx2_rel on ...
4 years, 9 months ago (2016-03-16 13:34:34 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808733002/20001
4 years, 9 months ago (2016-03-16 14:14:16 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 14:37:45 UTC) #11
danno
lgtm
4 years, 9 months ago (2016-03-18 16:43:41 UTC) #12
Michael Starzinger
LGTM (rubber-stamped).
4 years, 9 months ago (2016-03-18 18:38:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808733002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808733002/80001
4 years, 9 months ago (2016-03-21 09:49:52 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-21 12:03:40 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 12:03:58 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/06832bdcd26f8ce10b67a9052517918e0075a8d7
Cr-Commit-Position: refs/heads/master@{#34931}

Powered by Google App Engine
This is Rietveld 408576698