Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: tools/telemetry/telemetry/page/page_set_unittest.py

Issue 180873008: Add support for python pageset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_set_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_set_unittest.py b/tools/telemetry/telemetry/page/page_set_unittest.py
index 3a55651098fe08c923063f2923f49fde83c656c8..9d7da9845c2605a91e74d58c860568683c73b7b1 100644
--- a/tools/telemetry/telemetry/page/page_set_unittest.py
+++ b/tools/telemetry/telemetry/page/page_set_unittest.py
@@ -9,6 +9,7 @@ import unittest
from telemetry.page import page_set
+SRC_DIR = os.path.dirname(os.path.realpath(__file__))
simple_archive_info = """
{
"archives": {
@@ -33,10 +34,10 @@ simple_set = """
class TestPageSet(unittest.TestCase):
def testSimpleSet(self):
try:
- with tempfile.NamedTemporaryFile(delete=False) as f:
+ with tempfile.NamedTemporaryFile(delete=False, suffix=".json") as f:
f.write(simple_archive_info)
- with tempfile.NamedTemporaryFile(delete=False) as f2:
+ with tempfile.NamedTemporaryFile(delete=False, suffix=".json") as f2:
f2.write(simple_set % f.name.replace('\\', '\\\\'))
ps = page_set.PageSet.FromFile(f2.name)
@@ -71,3 +72,19 @@ class TestPageSet(unittest.TestCase):
self.assertEquals(ps.serving_dirs, expected_serving_dirs)
self.assertEquals(ps[0].serving_dir, os.path.join(real_directory_path, 'c'))
self.assertEquals(ps[2].serving_dir, os.path.join(real_directory_path, 'd'))
+
+
+ def testSuccesfulPythonPageSetLoading(self):
+ pps = page_set.PageSet.FromFile(
+ os.path.join(SRC_DIR, 'unittest_data/test_page_set.py'))
+ self.assertEqual('PageSetTest', pps.__class__.__name__)
+ self.assertEqual('A pageset for testing purpose', pps.description)
+ self.assertEqual('data/test.json', pps.archive_data_file)
+ self.assertEqual('data/credential', pps.credentials_path)
+ self.assertEqual('desktop', pps.user_agent_type)
+ self.assertEqual(1, len(pps.pages))
+ google_page = pps.pages[0]
+ self.assertEqual('https://www.google.com', google_page.url)
+ self.assertIs(pps, google_page.page_set)
+ self.assertTrue('navigate_steps' in dir(google_page))
+ self.assertTrue(5, google_page.get_action_runner(action_runner=5))

Powered by Google App Engine
This is Rietveld 408576698