tools/telemetry/telemetry/core/browser_credentials.py - Issue 180873008: Add support for python pageset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_credentials.py

Issue 180873008: Add support for python pageset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/browser_credentials.py

diff --git a/tools/telemetry/telemetry/core/browser_credentials.py b/tools/telemetry/telemetry/core/browser_credentials.py

index 80fb181c54beeed906411ac8e180731efe78673e..e1dea27d3d9dd4a10e9feccd4f7ed93dff8acd2d 100644

--- a/tools/telemetry/telemetry/core/browser_credentials.py

+++ b/tools/telemetry/telemetry/core/browser_credentials.py

@@ -115,7 +115,7 @@ class BrowserCredentials(object):

def WarnIfMissingCredentials(self, page_set):

num_pages_missing_login = 0

missing_credentials = set()

- for page in page_set:

+ for page in page_set.pages:

if (page.credentials

and not self.CanLogin(page.credentials)):

num_pages_missing_login += 1