tools/telemetry/telemetry/page/page_test_runner.py - Issue 180873008: Add support for python pageset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test_runner.py

Issue 180873008: Add support for python pageset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove attributes from page constructor Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_test_runner.py

diff --git a/tools/telemetry/telemetry/page/page_test_runner.py b/tools/telemetry/telemetry/page/page_test_runner.py

index 18bc69cce929cce76c15794b15a82bba6cb9ce66..369c19e627bb48c9354d2eac050242ac0dcda748 100644

--- a/tools/telemetry/telemetry/page/page_test_runner.py

+++ b/tools/telemetry/telemetry/page/page_test_runner.py

@@ -95,8 +95,8 @@ class PageTestRunner(object):

'pages': [{'url': page_set_arg}]

}, os.path.dirname(__file__))

- # We've been given a page set JSON. Load it.

- if page_set_arg.endswith('.json'):

+ # We've been given a page set JSON or PYTHON. Load it.

+ if page_set_arg.endswith('.json') or page_set_arg.endswith('.py'):

return page_set.PageSet.FromFile(page_set_arg)

# We've been given a file or directory. Create a page set containing it.