Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: tools/telemetry/telemetry/page/actions/page_action.py

Issue 180873008: Add support for python pageset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove attributes from page constructor Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/page_action.py
diff --git a/tools/telemetry/telemetry/page/actions/page_action.py b/tools/telemetry/telemetry/page/actions/page_action.py
index 04e7427ab7c881c10f7db66442fb88b937c63c23..f3428883f4cd6d9bf0bbec3588efc0e833b0544a 100644
--- a/tools/telemetry/telemetry/page/actions/page_action.py
+++ b/tools/telemetry/telemetry/page/actions/page_action.py
@@ -30,17 +30,6 @@ class PageAction(object):
else:
self.wait_until = None
- def CustomizeBrowserOptionsForPageSet(self, options):
- """Override to add action-specific options to the BrowserOptions
- object. These options will be set for the whole page set.
-
- If the browser is not being restarted for every page in the page set then
- all browser options required for the action must be set here. This, however,
- requires that they do not conflict with options require by other actions
- used up by the page set.
- """
- pass
-
def WillRunAction(self, page, tab):
"""Override to do action-specific setup before
Test.WillRunAction is called."""
« no previous file with comments | « tools/telemetry/telemetry/page/actions/action_runner.py ('k') | tools/telemetry/telemetry/page/actions/scroll_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698