third_party/pkg/angular/lib/tools/parser_getter_setter/generator.dart - Issue 180873006: Update the Angular/DI tests to latest from github.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/pkg/angular/lib/tools/parser_getter_setter/generator.dart

Issue 180873006: Update the Angular/DI tests to latest from github. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Review feedback Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/pkg/angular/lib/tools/parser_generator/generator.dart ('k') | third_party/pkg/angular/lib/tools/reserved_dart_keywords.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/pkg/angular/lib/tools/parser_getter_setter/generator.dart

diff --git a/third_party/pkg/angular/lib/tools/parser_getter_setter/generator.dart b/third_party/pkg/angular/lib/tools/parser_getter_setter/generator.dart

index e1b4b7de5d98d51f73aa6220e2a532b01f612686..b33244e104b718883af7a773ffb96b65c70f07fd 100644

--- a/third_party/pkg/angular/lib/tools/parser_getter_setter/generator.dart

+++ b/third_party/pkg/angular/lib/tools/parser_getter_setter/generator.dart

@@ -1,5 +1,5 @@

import 'package:angular/core/parser/parser.dart';

-import 'package:angular/tools/reserved_dart_keywords.dart';

+import 'package:angular/utils.dart' show isReservedWord;

import 'dart:math';

class DartGetterSetterGen extends ParserBackend {

@@ -9,12 +9,12 @@ class DartGetterSetterGen extends ParserBackend {

bool isAssignable(expression) => true;

registerAccess(String name) {

- if (isReserved(name)) return;

+ if (isReservedWord(name)) return;

properties.add(name);

}

registerCall(String name, List arguments) {

- if (isReserved(name)) return;

+ if (isReservedWord(name)) return;

Set<int> arities = calls.putIfAbsent(name, () => new Set<int>());

arities.add(arguments.length);

}