third_party/pkg/angular/lib/tools/selector.dart - Issue 180873006: Update the Angular/DI tests to latest from github.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/pkg/angular/lib/tools/selector.dart

Issue 180873006: Update the Angular/DI tests to latest from github. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Review feedback Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/pkg/angular/lib/tools/reserved_dart_keywords.dart ('k') | third_party/pkg/angular/lib/tools/source_metadata_extractor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/pkg/angular/lib/tools/selector.dart

diff --git a/third_party/pkg/angular/lib/tools/selector.dart b/third_party/pkg/angular/lib/tools/selector.dart

index 1db5a5bab74d88b6b37847769714123c5cc23375..01cb503c656c412ff8f07d7e3dc5314fff11e7aa 100644

--- a/third_party/pkg/angular/lib/tools/selector.dart

+++ b/third_party/pkg/angular/lib/tools/selector.dart

@@ -111,17 +111,9 @@ bool matchesNode(Node node, String selector) {

});

return stillGood;

- } else {

- throw new ArgumentError('Unsupported Selector: $selector');

- }

- switch(node.nodeType) {

- case 1: // Element

- break;

- case 3: // Text Node

- break;

- }

- return false;

+ }

+ throw new ArgumentError('Unsupported Selector: $selector');

}

String _matchingKey(Iterable keys, String attrName) =>