Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/pkg/angular/test/directive/ng_a_spec.dart

Issue 180873006: Update the Angular/DI tests to latest from github. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review feedback Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/pkg/angular/test/directive/ng_a_spec.dart
diff --git a/third_party/pkg/angular/test/directive/ng_a_spec.dart b/third_party/pkg/angular/test/directive/ng_a_spec.dart
index 082da14484aee9ae9587aa835d5b149d59f5ca4e..0612495eca2f100d72fd7ee93354672a4529810c 100644
--- a/third_party/pkg/angular/test/directive/ng_a_spec.dart
+++ b/third_party/pkg/angular/test/directive/ng_a_spec.dart
@@ -12,18 +12,19 @@ main() {
it('should bind click listener when href zero length string', inject((Scope scope) {
_.compile('<a href="" ng-click="abc = true; event = \$event"></a>');
_.triggerEvent(_.rootElement, 'click', 'MouseEvent');
- expect(_.rootScope['abc']).toEqual(true);
- expect(_.rootScope['event'] is dom.UIEvent).toEqual(true);
+ expect(_.rootScope.context['abc']).toEqual(true);
+ expect(_.rootScope.context['event'] is dom.UIEvent).toEqual(true);
}));
it('should bind click listener when href empty', inject((Scope scope) {
_.compile('<a href ng-click="abc = true; event = \$event"></a>');
_.triggerEvent(_.rootElement, 'click', 'MouseEvent');
- expect(_.rootScope['abc']).toEqual(true);
- expect(_.rootScope['event'] is dom.UIEvent).toEqual(true);
+ expect(_.rootScope.context['abc']).toEqual(true);
+ expect(_.rootScope.context['event'] is dom.UIEvent).toEqual(true);
}));
it('should not bind click listener to non empty href', inject((Scope scope) {
+ window.location.href = '#something';
_.compile('<a href="#"></a>');
_.triggerEvent(_.rootElement, 'click', 'MouseEvent');
expect(window.location.href.endsWith("#")).toEqual(true);
@@ -32,11 +33,11 @@ main() {
it('should not cancel click with non-empty interpolated href', inject((Scope scope) {
_.compile('<a href="{{url}}" ng-click="abc = true; event = \$event"></a>');
_.triggerEvent(_.rootElement, 'click', 'MouseEvent');
- expect(_.rootScope['abc']).toEqual(true);
- expect(_.rootScope['event'] is dom.UIEvent).toEqual(true);
+ expect(_.rootScope.context['abc']).toEqual(true);
+ expect(_.rootScope.context['event'] is dom.UIEvent).toEqual(true);
window.location.href = '#';
- _.rootScope['url'] = '#url';
- _.rootScope.$digest();
+ _.rootScope.context['url'] = '#url';
+ _.rootScope.apply();
_.triggerEvent(_.rootElement, 'click', 'MouseEvent');
expect(window.location.href.endsWith("#url")).toEqual(true);
}));

Powered by Google App Engine
This is Rietveld 408576698