third_party/pkg/angular/test/directive/ng_include_spec.dart - Issue 180873006: Update the Angular/DI tests to latest from github.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/pkg/angular/test/directive/ng_include_spec.dart

Issue 180873006: Update the Angular/DI tests to latest from github. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Review feedback Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/pkg/angular/test/directive/ng_if_spec.dart ('k') | third_party/pkg/angular/test/directive/ng_model_spec.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/pkg/angular/test/directive/ng_include_spec.dart

diff --git a/third_party/pkg/angular/test/directive/ng_include_spec.dart b/third_party/pkg/angular/test/directive/ng_include_spec.dart

index a192106753eb9ac1526982196863dd67a473c3ca..625821bdc34938e4b80563a8a122ea3bd247ad3d 100644

--- a/third_party/pkg/angular/test/directive/ng_include_spec.dart

+++ b/third_party/pkg/angular/test/directive/ng_include_spec.dart

@@ -16,8 +16,8 @@ main() {

expect(element.innerHtml).toEqual('');

microLeap(); // load the template from cache.

- scope.$apply(() {

- scope['name'] = 'Vojta';

+ scope.applyInZone(() {

+ scope.context['name'] = 'Vojta';

});

expect(element.text).toEqual('my name is Vojta');

})));

@@ -30,14 +30,14 @@ main() {

expect(element.innerHtml).toEqual('');

- scope.$apply(() {

- scope['name'] = 'Vojta';

- scope['template'] = 'tpl1.html';

+ scope.applyInZone(() {

+ scope.context['name'] = 'Vojta';

+ scope.context['template'] = 'tpl1.html';

});

expect(element.text).toEqual('My name is Vojta');

- scope.$apply(() {

- scope['template'] = 'tpl2.html';

+ scope.applyInZone(() {

+ scope.context['template'] = 'tpl2.html';

});

expect(element.text).toEqual('I am Vojta');

})));