Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1808723002: Google3 apps are still using Create* shader methods. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
dogben, reed1
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Google3 apps are still using Create* shader methods. This may need to go in DEFINES_ALL, but definitely needs to affect the main _UNIX builds. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1808723002 Committed: https://skia.googlesource.com/skia/+/9552ed31c1b4fdb02a5a2df36652caad44873100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 9 months ago (2016-03-16 13:21:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808723002/1
4 years, 9 months ago (2016-03-16 13:21:10 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-16 13:21:12 UTC) #6
reed1
lgtm
4 years, 9 months ago (2016-03-16 13:25:27 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 13:35:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9552ed31c1b4fdb02a5a2df36652caad44873100

Powered by Google App Engine
This is Rietveld 408576698