Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: runtime/bin/socket_android.cc

Issue 18087003: Fix comment from earlier commit. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/socket_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_android.cc
diff --git a/runtime/bin/socket_android.cc b/runtime/bin/socket_android.cc
index ac3f5c385767b2dcc617830b6270d6a9e84c1384..dd0e2569eadca52991c873fb56c8417dae2e0ae4 100644
--- a/runtime/bin/socket_android.cc
+++ b/runtime/bin/socket_android.cc
@@ -286,8 +286,8 @@ intptr_t ServerSocket::CreateBindListen(RawAddr addr,
// Test for invalid socket port 65535 (some browsers disallow it).
if (port == 0 && Socket::GetPort(fd) == 65535) {
- // Don't close fd until we have created new. By doing that we ensure another
- // port.
+ // Don't close the socket until we have created a new socket, ensuring
+ // that we do not get the bad port number again.
intptr_t new_fd = CreateBindListen(addr, 0, backlog, v6_only);
int err = errno;
VOID_TEMP_FAILURE_RETRY(close(fd));
« no previous file with comments | « no previous file | runtime/bin/socket_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698